Sub: Fix SET_POSITION_TARGET_LOCAL_NED to be above origin #19995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Feb 4, 2022
|
Yes, we replaced these "pv_" (Position Vector) methods a long time ago in Copter so it makes sense to do the same in Sub. You've tested it of course? |
hendjoshsr71
force-pushed
the
pr/sub_fix_local_ned_above_ekf_origin
branch
from
2930ae4
to
a3ea60c
Compare
Yes, still circles and points at ROIs. |
Williangalvani
approved these changes
Feb 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SET_POSITION_TARGET_LOCAL_NED to be above origin as is the standard . https://mavlink.io/en/messages/common.html#MAV_FRAME_LOCAL_NED
Also removes some redundant code to use functions that exist in AP_Location